Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62086318
--- Diff: python/pyspark/ml/tests.py ---
@@ -1027,6 +1027,21 @@ def test_storage_levels(self):
self.assertEqual(als.getFinalStorageLevel(), "DISK_ONLY")
self.assertEqual(als._java_obj.getFinalStorageLevel(), "DISK_ONLY")
+ def test_unknown_strategy(self):
--- End diff --
I think its probably good habit to add tests for new complex params we add
(but probably not worth it to go back and fill it in). I know that as a user
when the docs don't explain stuff closely enough turning to the tests is often
a good fall back (so we can think of it as also helping with documentation in a
way).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
