Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15051#discussion_r79297392
--- Diff: R/pkg/R/mllib.R ---
@@ -694,8 +694,14 @@ setMethod("predict", signature(object = "KMeansModel"),
#' }
#' @note spark.mlp since 2.1.0
setMethod("spark.mlp", signature(data = "SparkDataFrame"),
- function(data, blockSize = 128, layers = c(3, 5, 2), solver =
"l-bfgs", maxIter = 100,
- tol = 0.5, stepSize = 1, seed = 1) {
+ function(data, layers, blockSize = 128, solver = "l-bfgs",
maxIter = 100,
+ tol = 1E-6, stepSize = 0.03, seed = 0x7FFFFFFF) {
+ if (length(layers) <= 1) {
+ stop("layers vector require length > 0.")
+ }
+ if (any(sapply(layers, function(e) !is.numeric(e)))) {
--- End diff --
oh, its a clever way using `as.intege(x) != x` to check whether it is an
integer.
here the mlp require layers to be integer vector,
is it better to force user pass integer vector, if not call `stop`, or just
print a warning ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
