Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15051#discussion_r79356231
  
    --- Diff: R/pkg/inst/tests/testthat/test_mllib.R ---
    @@ -387,6 +387,11 @@ test_that("spark.mlp", {
       model <- spark.mlp(df, layers = c(4, 5, 4, 3))
       mlpPredictions <- collect(select(predict(model, mlpTestDF), 
"prediction"))
       expect_equal(head(mlpPredictions$prediction, 10), c(1, 1, 1, 1, 0, 1, 2, 
2, 1, 0))
    +
    +  # Test illegal parameter
    +  expect_error(spark.mlp(df, layers = NULL))
    --- End diff --
    
    it would be preferred to add the error string to check for (the message in 
stop()) - please see our other tests on how to do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to