Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15051#discussion_r79356288
--- Diff: R/pkg/R/mllib.R ---
@@ -695,17 +695,15 @@ setMethod("predict", signature(object =
"KMeansModel"),
#' @note spark.mlp since 2.1.0
setMethod("spark.mlp", signature(data = "SparkDataFrame"),
function(data, layers, blockSize = 128, solver = "l-bfgs",
maxIter = 100,
- tol = 1E-6, stepSize = 0.03, seed = 0x7FFFFFFF) {
+ tol = 1E-6, stepSize = 0.03, seed = "") {
--- End diff --
this is a bit unusual in R, also could cause confusion as to what should be
passed in (string? integer?) - how about we default to NULL and then check
inside spark.mlp to map seed NULL to "" (only that)?
also if seed is not NULL it should be coerce into integer (as.integer(seed))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
