Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10212#discussion_r80137783
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -759,7 +761,15 @@ private[spark] object JsonProtocol {
           return metrics
         }
         metrics.setExecutorDeserializeTime((json \ "Executor Deserialize 
Time").extract[Long])
    +    metrics.setExecutorDeserializeCpuTime((json \ "Executor Deserialize 
CPU Time") match {
    +      case JNothing => 0
    +      case x => x.extract[Long]}
    +    )
         metrics.setExecutorRunTime((json \ "Executor Run Time").extract[Long])
    +    metrics.setExecutorCpuTime((json \ "Executor CPU Time") match {
    +      case JNothing => 0
    +      case x => x.extract[Long]}
    --- End diff --
    
    nit: move '}' to next line (with the ')'). Also above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to