Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10212#discussion_r80137728
  
    --- Diff: 
core/src/test/resources/HistoryServerExpectations/complete_stage_list_json_expectation.json
 ---
    @@ -6,6 +6,7 @@
       "numCompleteTasks" : 8,
       "numFailedTasks" : 0,
       "executorRunTime" : 162,
    +  "executorCpuTime" : 0,
    --- End diff --
    
    Do you need to add these values to all these files? The code should be able 
to handle the old logs that don't have the value, and not adding these would be 
a good test case for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to