Github user jisookim0513 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10212#discussion_r80155278
  
    --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala 
---
    @@ -1097,7 +1100,9 @@ private[spark] object JsonProtocolSuite extends 
Assertions {
           |  },
           |  "Task Metrics": {
           |    "Executor Deserialize Time": 300,
    +      |    "Executor Deserialize CPU Time": 0,
    --- End diff --
    
    AFAIK, JsonProtolSuite creates a JSON string from the event created by 
`makeTaskMetrics()`:
    'makeTaskMetrics(300L, 400L, 500L, 600L, 700, 800, hasHadoopInput = true, 
hasOutput = false))'.
    I tried changing `makeTaskMetrics()` to accept deserialize CPU time and CPU 
time as arguments , but that ended up violating scalaStyle by having more than 
10 parameters.. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to