Github user vanzin commented on a diff in the pull request:
    --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala 
    @@ -1097,7 +1100,9 @@ private[spark] object JsonProtocolSuite extends 
Assertions {
           |  },
           |  "Task Metrics": {
           |    "Executor Deserialize Time": 300,
    +      |    "Executor Deserialize CPU Time": 0,
    --- End diff --
    I still think it would be worth to fix this; just find some way around the 
style check.
    Otherwise, you're not really testing whether the parsing code is actually 
parsing the field (what if there's a typo somewhere?).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to