Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17450#discussion_r108720512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -384,33 +379,13 @@ case class NullPropagation(conf: CatalystConf)
extends Rule[LogicalPlan] {
Coalesce(newChildren)
}
- case e @ Substring(Literal(null, _), _, _) => Literal.create(null,
e.dataType)
- case e @ Substring(_, Literal(null, _), _) => Literal.create(null,
e.dataType)
- case e @ Substring(_, _, Literal(null, _)) => Literal.create(null,
e.dataType)
-
- // Put exceptional cases above if any
- case e @ BinaryArithmetic(Literal(null, _), _) =>
Literal.create(null, e.dataType)
- case e @ BinaryArithmetic(_, Literal(null, _)) =>
Literal.create(null, e.dataType)
-
- case e @ BinaryComparison(Literal(null, _), _) =>
Literal.create(null, e.dataType)
- case e @ BinaryComparison(_, Literal(null, _)) =>
Literal.create(null, e.dataType)
-
- case e: StringRegexExpression => e.children match {
- case Literal(null, _) :: right :: Nil => Literal.create(null,
e.dataType)
- case left :: Literal(null, _) :: Nil => Literal.create(null,
e.dataType)
- case _ => e
- }
-
- case e: StringPredicate => e.children match {
- case Literal(null, _) :: right :: Nil => Literal.create(null,
e.dataType)
- case left :: Literal(null, _) :: Nil => Literal.create(null,
e.dataType)
- case _ => e
- }
-
// If the value expression is NULL then transform the In expression
to
// Literal(null)
case In(Literal(null, _), list) => Literal.create(null, BooleanType)
+ // Put exceptional cases above if any
--- End diff --
I might be confused with the terminologies: `NullIntolerant` expression
versus "null-intolerant predicate". But if SUBSTRING is marked null-intolerant
expression, why do we not mark the class of string functions such as CONTAINS,
STARTSWITH, etc. the same way? Am I missing anything here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
