Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/17450#discussion_r108720888
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1122,7 +1119,7 @@ case class StringSpace(child: Expression)
""")
// scalastyle:on line.size.limit
case class Substring(str: Expression, pos: Expression, len: Expression)
- extends TernaryExpression with ImplicitCastInputTypes {
+ extends TernaryExpression with ImplicitCastInputTypes with
NullIntolerant {
--- End diff --
I might be confused with the terminologies: NullIntolerant expression
versus "null-intolerant predicate". But if SUBSTRING is marked null-intolerant
expression, why do we not mark the class of string functions such as CONTAINS,
STARTSWITH, etc. the same way? Am I missing anything here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
