Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17450#discussion_r108785672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1122,7 +1119,7 @@ case class StringSpace(child: Expression)
""")
// scalastyle:on line.size.limit
case class Substring(str: Expression, pos: Expression, len: Expression)
- extends TernaryExpression with ImplicitCastInputTypes {
+ extends TernaryExpression with ImplicitCastInputTypes with
NullIntolerant {
--- End diff --
At the beginning, when we introduce `NullIntolerant `, @marmbrus said we
should do it more carefully. We prefer to using the white-list solution for
avoiding hidden bugs. Marking it `NullIntolerant` if and only if we are ensure
that they are null intolerant. Thus, when we doing it, we should also add the
corresponding test cases and documents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
