Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17450#discussion_r108837093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -297,8 +297,8 @@ case class Lower(child: Expression) extends
UnaryExpression with String2StringEx
}
/** A base trait for functions that compare two strings, returning a
boolean. */
-trait StringPredicate extends Predicate with ImplicitCastInputTypes {
- self: BinaryExpression =>
+abstract class StringPredicate extends BinaryExpression
+ with Predicate with ImplicitCastInputTypes {
--- End diff --
I finally got your point. `StringPredicate` is used for inferring the null
constants in the rule `NullPropagation`. Thus, we should mark it as
`NullIntolerant `.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
