Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17665#discussion_r112005729
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala
---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.spark.deploy.yarn.security
+package org.apache.spark.deploy.security
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.security.{Credentials, UserGroupInformation}
--- End diff --
The code in the "yarn" module is sort of considered "private", so anyone
extending those classes is walking on thin ice... the internal services files
need to be moved / updated, but I don't think we need to worry about external
implementations.
This also means we need to be more careful here when making classes /
traits public. Maybe add `@InterfaceStability.Evolving` annotations if they
haven't been added, or something.
(Haven't looked at the rest of the code yet, kinda waiting for the PR
builder to be happy first.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
