Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17665#discussion_r112041944
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala
---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.spark.deploy.yarn.security
+package org.apache.spark.deploy.security
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.security.{Credentials, UserGroupInformation}
--- End diff --
Hmm... that's unfortunate, not just because of this change, but because
`yarn/` is not included in mima checks, so if the class changed in incompatible
ways we wouldn't notice.
I really doubt anyone has custom implementations of that interface at this
point. And making it a proper API in core is better going forward, IMO. If you
really think that it's important to keep backwards compatibility, we could have
the old interface present, extending the new one, and some compatibility code
to keep both working. But that sounds like a lot of work for something I doubt
anyone is currently using...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
