Github user mridulm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17665#discussion_r112047159
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala
 ---
    @@ -15,7 +15,7 @@
      * limitations under the License.
      */
     
    -package org.apache.spark.deploy.yarn.security
    +package org.apache.spark.deploy.security
     
     import org.apache.hadoop.conf.Configuration
     import org.apache.hadoop.security.{Credentials, UserGroupInformation}
    --- End diff --
    
    @vanzin Would be good to keep backward compatibility since there are users 
of the interface.
    I did not realize yarn was excluded from MIMA - that is unfortunate.
    
    Cursory look at ServiceLoader seemed to indicate it might be very involved 
to provide backward compatibility (`yarn` interface extends from `core`, load 
for both interfaces; and use both as `core` impl will do ? or did I miss 
something here ?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to