Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/17665#discussion_r112040364
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/ServiceCredentialProvider.scala
---
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.spark.deploy.yarn.security
+package org.apache.spark.deploy.security
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.security.{Credentials, UserGroupInformation}
--- End diff --
@vanzin Since this is documented in running-on-yarn.md, I dont think it can
be considered internal implementation detail anymore; but it is part of our
exposed contract.
@mgummelt I did see that all spark impl have been moved - but since this is
an exposed contract, there can be (and are) external implementations which rely
on it.
If we are breaking api compatibility, we should be very explicit about it :
I wanted to make sure it is called out, and evaluated accordingly (and not an
internal implementation detail within yarn/core).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
