Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r119724691
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -38,6 +40,7 @@ private[kinesis] class KinesisInputDStream[T: ClassTag](
val endpointUrl: String,
val regionName: String,
val initialPositionInStream: InitialPositionInStream,
+ val initialPositionInStreamTimestamp: Date,
--- End diff --
I think there needs to be a better abstraction around the
```initialPositionInStream``` and ```initialPositionInStreamTimestamp```
options. Providing both is redundant as a user would want to specify one or the
other. Additionally, if ```initialPositionInStreamTimestamp``` is an optional
value then its type should at the very least be ```Option[Date]``` with a
default value of ```None```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
