Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r120180756
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -100,6 +103,7 @@ object KinesisInputDStream {
private var endpointUrl: Option[String] = None
private var regionName: Option[String] = None
private var initialPositionInStream: Option[InitialPositionInStream] =
None
+ private var initialPositionInStreamTimestamp: Option[Date] = None
--- End diff --
umm, I feel a better way would be like:
```scala
trait InitialPosition {
def setInitialPosition(clientConf: KinesisClientLibConfiguration):
KinesisClientLibConfiguration
}
case object Latest {
override def setInitialPosition(clientConf:
KinesisClientLibConfiguration): KinesisClientLibConfiguration = {
clientLibConf.withInitialPositionInStream(InitialPositionInStream.LATEST)
}
}
case object TrimHorizon {
override def setInitialPosition(clientConf:
KinesisClientLibConfiguration): KinesisClientLibConfiguration = {
clientLibConf.withInitialPositionInStream(InitialPositionInStream.TRIM_HORIZON)
}
}
case class AtTimestamp(timestamp: Date) {
override def setInitialPosition(clientConf:
KinesisClientLibConfiguration): KinesisClientLibConfiguration = {
clientLibConf. withTimestampAtInitialPositionInStream(timestamp)
}
}
```
what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
