Github user yssharma commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r119986280
--- Diff:
external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisInputDStreamBuilderSuite.scala
---
@@ -111,5 +110,28 @@ class KinesisInputDStreamBuilderSuite extends
TestSuiteBase with BeforeAndAfterE
assert(dstream.kinesisCreds == customKinesisCreds)
assert(dstream.dynamoDBCreds == Option(customDynamoDBCreds))
assert(dstream.cloudWatchCreds == Option(customCloudWatchCreds))
+
+ val yesterday = DateUtils.addDays(new Date, -1)
+ val dStreamFromTimestamp = builder
+ .endpointUrl(customEndpointUrl)
+ .regionName(customRegion)
+ .initialPositionInStream(InitialPositionInStream.AT_TIMESTAMP,
Some(yesterday))
--- End diff --
@budde Added optional timestamp for resume, but passing as Some() doesn't
seem very interesting. Passing a date directly seems more intuitive. Thoughts ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
