Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/18029#discussion_r119725220
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
---
@@ -73,7 +73,7 @@ object KinesisUtils {
// Setting scope to override receiver stream's scope of "receiver
stream"
ssc.withNamedScope("kinesis stream") {
new KinesisInputDStream[T](ssc, streamName, endpointUrl,
validateRegion(regionName),
- initialPositionInStream, kinesisAppName, checkpointInterval,
storageLevel,
+ initialPositionInStream, null, kinesisAppName, checkpointInterval,
storageLevel,
--- End diff --
Passing a ```null``` for an optional value is very un-idiomatic for Scala
code. As noted in my previous comment, we should find a way to pass a single
config option that represents all possible InitialPositionInStream
configurations or at the very least make this argument an ```Option[Date]```
with a default value of ```None```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
