Github user adrian-ionescu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18884#discussion_r132130615
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
 ---
    @@ -128,6 +128,7 @@ class FileStreamSink(
             hadoopConf = hadoopConf,
             partitionColumns = partitionColumns,
             bucketSpec = None,
    +        statsTrackers = Nil,
    --- End diff --
    
    We might, but it wasn't originally handled in 
https://github.com/apache/spark/pull/18159 and so `FileStreamSink` doesn't 
extend `DataWritingCommand`.
    @viirya, do you remember if there was any particular reason for this, or 
was it just overlooked / deemed out of scope?
    Anyway, I could try to add handling for it in this PR, but I'd say it's 
rather orthogonal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to