Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17849#discussion_r132358656
  
    --- Diff: python/pyspark/ml/wrapper.py ---
    @@ -263,7 +284,8 @@ def _fit_java(self, dataset):
     
         def _fit(self, dataset):
             java_model = self._fit_java(dataset)
    -        return self._create_model(java_model)
    +        model = self._create_model(java_model)
    +        return self._copyValues(model)
    --- End diff --
    
    Here I think it is going to copy values from the estimator to the created 
model. So I think we assume that the params in estimator and model are the same?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to