Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/17849#discussion_r132516315
--- Diff: python/pyspark/ml/classification.py ---
@@ -1325,7 +1325,7 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
super(MultilayerPerceptronClassifier, self).__init__()
self._java_obj = self._new_java_obj(
"org.apache.spark.ml.classification.MultilayerPerceptronClassifier", self.uid)
- self._setDefault(maxIter=100, tol=1E-4, blockSize=128,
stepSize=0.03, solver="l-bfgs")
+ self._setDefault(maxIter=100, tol=1E-6, blockSize=128,
stepSize=0.03, solver="l-bfgs")
--- End diff --
Yes, the `check_params` test was meant to catch that but was broken
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
