Github user viirya commented on a diff in the pull request:
    --- Diff: python/pyspark/ml/ ---
    @@ -1572,7 +1588,8 @@ def test_java_params(self):
                 for name, cls in inspect.getmembers(module, inspect.isclass):
                     if not name.endswith('Model') and issubclass(cls, 
                             and not inspect.isabstract(cls):
    -                    self.check_params(cls())
    +                    # NOTE: disable check_params_exist until there is 
parity with Scala API
    +                    ParamTests.check_params(self, cls(), 
    --- End diff --
    This skips param test for Model. Should we do similar check to all models?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to