Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17849#discussion_r132359369
  
    --- Diff: python/pyspark/ml/wrapper.py ---
    @@ -144,7 +158,9 @@ def _transfer_params_from_java(self):
                 if self._java_obj.hasParam(param.name):
                     java_param = self._java_obj.getParam(param.name)
                     # SPARK-14931: Only check set params back to avoid default 
params mismatch.
    -                if self._java_obj.isSet(java_param):
    +                if self._java_obj.isSet(java_param) or (
    +                        # SPARK-10931: Temporary fix for params that have 
a default in Java
    +                        self._java_obj.hasDefault(java_param) and not 
self.isDefined(param)):
    --- End diff --
    
    This change will make a default value for a param in java side as an 
user-provided param value in python side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to