Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17849#discussion_r132531194
  
    --- Diff: python/pyspark/ml/tests.py ---
    @@ -1572,7 +1588,8 @@ def test_java_params(self):
                 for name, cls in inspect.getmembers(module, inspect.isclass):
                     if not name.endswith('Model') and issubclass(cls, 
JavaParams)\
                             and not inspect.isabstract(cls):
    -                    self.check_params(cls())
    +                    # NOTE: disable check_params_exist until there is 
parity with Scala API
    +                    ParamTests.check_params(self, cls(), 
check_params_exist=False)
    --- End diff --
    
    Yes, ideally but most of the models need to be trained first so that is why 
they are skipped here.  Some basic framework would need to be added to allow 
this, and I'm looking into that as a follow on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to