Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133999734
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
client.listFunctions(db, pattern)
}
+ /** Detect whether a table is stored with Hive-compatible metadata. */
+ private def isHiveCompatible(table: CatalogTable): Boolean = {
--- End diff --
Let me revert the question for you: why is it bad to have the compatibility
bit be a table property?
You cannot make a non-compatible table compatible after it's been created.
At the very least, there is zero code that would achieve that today. And the
key to this fix is that the `alterTableSchema` method needs to know whether the
table is compatible or not in a reliable way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
