Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18849#discussion_r134000329
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -1175,6 +1205,27 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
         client.listFunctions(db, pattern)
       }
     
    +  /** Detect whether a table is stored with Hive-compatible metadata. */
    +  private def isHiveCompatible(table: CatalogTable): Boolean = {
    --- End diff --
    
    And, also, if you look at `createDataSourceTable`, it does more checks that 
your example to decide whether a table is Hive-compatible or not. And the 
ultimate check is whether the Hive metastore accepts the table (exception means 
Spark tries to create the table again, as non-compatible).
    
    So, again, you cannot detect compatibility by just checking the schema.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to