Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20669#discussion_r173866657
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverConfigPropertiesStep.scala
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.submit.steps
    +
    +import java.io.StringWriter
    +import java.util.Properties
    +
    +import io.fabric8.kubernetes.api.model._
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.submit.KubernetesDriverSpec
    +
    +/**
    + * Create a config map with the driver configuration and attach it to the 
pod. This needs to
    + * come at the end of the driver configuration so that all modifications 
to the Spark config
    + * are reflected in the generated config map.
    + */
    +private[spark] class DriverConfigPropertiesStep(resourceNamePrefix: String)
    +    extends DriverConfigurationStep {
    +
    +  override def configureDriver(spec: KubernetesDriverSpec): 
KubernetesDriverSpec = {
    +    val configMapName = s"$resourceNamePrefix-driver-conf-map"
    +    val configMap = buildConfigMap(configMapName, spec.driverSparkConf)
    --- End diff --
    
    Not sure I understand why being able to declare things in any order is 
important.
    
    Not doing so means you'll have to pass properties as command line 
arguments. Which, in a way, is already enforcing ordering - it assumes that the 
code that sets those command line arguments runs last, so it can see all 
parameters.
    
    This approach also means you don't need to think about things such as java 
options. They're in the config file, which is processed by spark-submit. The 
whole point of this exercise was to avoid duplicating stuff that spark-submit 
already does.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to