Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20669#discussion_r174328774
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
 ---
    @@ -180,6 +179,26 @@ private[spark] class Client(
           
originalMetadata.setOwnerReferences(Collections.singletonList(driverPodOwnerReference))
         }
       }
    +
    +  // Build a Config Map that will house both the properties file and the 
java options file
    --- End diff --
    
    Maybe an incorrect javadoc, or else this is erroneously not putting in the 
java options file? Also where do we handle `spark.driver.extraJavaOptions` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to