Github user ifilonenko commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20669#discussion_r174345374
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
 ---
    @@ -89,26 +56,16 @@ private[spark] object KubernetesUtils {
       def getOnlyRemoteFiles(uris: Iterable[String]): Iterable[String] = {
         uris.filter { uri =>
           val scheme = Utils.resolveURI(uri).getScheme
    -      scheme != "file" && scheme != "local"
    +      scheme != "local"
    --- End diff --
    
    Unnecessary, but it should not be allowed in our Utils as we can't resolve 
the location without `SparkFiles.get()`which makes that logic useless. No? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to