Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20669#discussion_r174328964
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
 ---
    @@ -202,6 +221,10 @@ private[spark] class KubernetesClientApplication 
extends SparkApplication {
         val launchTime = System.currentTimeMillis()
         val waitForAppCompletion = sparkConf.get(WAIT_FOR_APP_COMPLETION)
         val appName = sparkConf.getOption("spark.app.name").getOrElse("spark")
    +    val kubernetesResourceNamePrefix = {
    +      val uuid = 
UUID.nameUUIDFromBytes(Longs.toByteArray(launchTime)).toString.replaceAll("-", 
"")
    --- End diff --
    
    Heh, UUIDs aren't great here because they tend to be very long. There's 
lots of inconvenient name length restrictions in Kubernetes. That's why we were 
just using the launch time before.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to