Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21619#discussion_r197611404
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
 ---
    @@ -148,14 +149,17 @@ trait Block extends JavaCode {
       }
     
       // Concatenates this block with other block.
    -  def + (other: Block): Block
    +  def + (other: Block): Block = other match {
    +    case EmptyBlock => this
    --- End diff --
    
    what if `this` is an `EmptyBlock`? shall we a case also for it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to