Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21619#discussion_r197611649
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -148,14 +149,17 @@ trait Block extends JavaCode {
}
// Concatenates this block with other block.
- def + (other: Block): Block
+ def + (other: Block): Block = other match {
+ case EmptyBlock => this
--- End diff --
sorry, probably the wrong line for the comment. I mean the case:
`EmptyBlock` + non-empty block. Shall we add a check and return other in that
case?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
