Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3144#discussion_r19981976
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
---
@@ -98,7 +98,9 @@ class ExecutorRunnable(
val secretString = securityMgr.getSecretKey()
val secretBytes =
if (secretString != null) {
- ShuffleSecretManager.stringToBytes(secretString)
+ // This uses a JavaUtils method because the reverse conversion
takes
--- End diff --
nit: not sure the comment is useful. Might as well say it uses JavaUtils
because that's where the method is implemented...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
