Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3144#discussion_r19983197
--- Diff:
network/common/src/main/java/org/apache/spark/network/util/JavaUtils.java ---
@@ -73,4 +77,20 @@ public static int nonNegativeHash(Object obj) {
int hash = obj.hashCode();
return hash != Integer.MIN_VALUE ? Math.abs(hash) : 0;
}
+
+ /**
+ * Convert the given string to a byte buffer. The resulting buffer can be
+ * converted back to the same string through {@link
#bytesToString(ByteBuffer)}.
+ */
+ public static ByteBuffer stringToBytes(String s) {
+ return ByteBuffer.wrap(s.getBytes(UTF8_CHARSET));
+ }
+
+ /**
+ * Convert the given byte buffer to a string. The resulting string can be
+ * converted back to the same byte buffer through {@link
#stringToBytes(String)}.
+ */
+ public static String bytesToString(ByteBuffer b) {
+ return new String(b.array(), UTF8_CHARSET);
--- End diff --
this is not safe for bytebuffers which are allocated off-heap -- Netty has
already looked at this problem, so maybe we should just use their solution:
```return Unpooled.wrappedBuffer(b).toString(Charsets.UTF_8)```
For symmetry, we could use
```Unpooled.wrappedBuffer(s.getBytes(Charsets.UTF_8)).nioByteBuffer()``` on
stringToBytes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
