Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3144#discussion_r19982930
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
---
@@ -98,7 +98,9 @@ class ExecutorRunnable(
val secretString = securityMgr.getSecretKey()
val secretBytes =
if (secretString != null) {
- ShuffleSecretManager.stringToBytes(secretString)
+ // This uses a JavaUtils method because the reverse conversion
takes
--- End diff --
Yeah maybe. It's just that it's not super intuitive why we need to use
`JavaUtils` in scala code when we could have used something from Spark's
`Utils`. I'd rather err on the safe side of being verbose. Maybe I'll reword
the comment a little to make it sound less stupid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
