Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20637#discussion_r212668425
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -223,8 +223,9 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks with PlanTestBa
               }
             } else {
               val lit = InternalRow(expected, expected)
    +          val dtAsNullable = expression.dataType.asNullable
    --- End diff --
    
    Ok, thanks now I think I got it. But I think that the NullPointerException 
is right to be thrown. That is what a user would get in such a situation. So I 
don't really think this change should be added.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to