Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20637#discussion_r212926645 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -223,8 +223,9 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks with PlanTestBa } } else { val lit = InternalRow(expected, expected) + val dtAsNullable = expression.dataType.asNullable --- End diff -- thanks for your comment @ueshin. If I am the only one with a different opinion that's ok, but I don't really agree, as it means that we are testing something different from what is run by users. Moreover the same can happen everywhere else in the codebase where we don't check nullabilities. Anyway, if I am the only one with a different opinion, that's fine. Thanks.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org