Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20637#discussion_r213013507 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -223,8 +223,9 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks with PlanTestBa } } else { val lit = InternalRow(expected, expected) + val dtAsNullable = expression.dataType.asNullable --- End diff -- @ueshin @cloud-fan Thank you for good summary. I think that this does not reduce test coverage. This ` dtAsNullable = expression.dataType.asNullable` is used only for generating `expected`. This `asNullable` does not change `dataType` of `expression`. Thus, this does not change our optimization assumption.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org