Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/3009#issuecomment-63129471
Sorry again for being slow to look at this!
I tried this out and, visually, it looks great -- the kill issue is fixed
and I like the new "?" help text and the stage progress bar.
I just have one comment about the code, which is that the code for
AllStagesPage.scala and JobPage.scala is very similar and I think should be
factored into a shared function that accepts a list of stages. It looks like
the only difference is the job group ID for the job page -- which it seems like
could be moved to the header ("Details for Job X (Job Group Y)") if it exists?
The only other issue is something we discussed earlier, which is what
happens if a map stage has to be recomputed due to a fetch failure? Do you end
up with more complete stages than stages in the job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
