srowen commented on a change in pull request #24140: [SPARK-27198][core]
Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r268099494
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -833,7 +836,8 @@ private[spark] class Executor(
val message = Heartbeat(executorId, accumUpdates.toArray,
env.blockManager.blockManagerId)
try {
val response = heartbeatReceiverRef.askSync[HeartbeatResponse](
- message, RpcTimeout(conf, "spark.executor.heartbeatInterval", "10s"))
+ message, new RpcTimeout(heartbeatInterval.millis.toSeconds.seconds,
+ EXECUTOR_HEARTBEAT_INTERVAL.key))
Review comment:
Nit: indent, or put the `new RpcTimeout` on this line if it fits. Same
comment about using TimeUnit consistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
