srowen commented on a change in pull request #24140: [SPARK-27198][core]
Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r268099654
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -855,15 +859,15 @@ private[spark] class Executor(
* Schedules a task to report heartbeat and partial metrics for active tasks
to driver.
*/
private def startDriverHeartbeater(): Unit = {
- val intervalMs = conf.getTimeAsMs("spark.executor.heartbeatInterval",
"10s")
-
// Wait a random interval so the heartbeats don't end up in sync
- val initialDelay = intervalMs + (math.random *
intervalMs).asInstanceOf[Int]
+ val initialDelay = heartbeatInterval + (math.random *
heartbeatInterval).asInstanceOf[Int]
val heartbeatTask = new Runnable() {
override def run(): Unit = Utils.logUncaughtExceptions(reportHeartBeat())
}
- heartbeater.scheduleAtFixedRate(heartbeatTask, initialDelay, intervalMs,
TimeUnit.MILLISECONDS)
+ heartbeater
Review comment:
This can be reverted then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
