srowen commented on a change in pull request #24140: [SPARK-27198][core] Heartbeat interval mismatch in driver and executor URL: https://github.com/apache/spark/pull/24140#discussion_r268098611
########## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ########## @@ -71,6 +72,8 @@ private[spark] class Executor( private val conf = env.conf + private val heartbeatInterval = conf.get(EXECUTOR_HEARTBEAT_INTERVAL) Review comment: Just to keep the change narrow and not introduce a field, I think this can stay local to the methods below. For clarity I'd retain the "Ms" suffix on the name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
