srowen commented on a change in pull request #24140: [SPARK-27198][core]
Heartbeat interval mismatch in driver and executor
URL: https://github.com/apache/spark/pull/24140#discussion_r268098450
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -610,7 +611,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
s"${NETWORK_AUTH_ENABLED.key} must be enabled when enabling encryption.")
val executorTimeoutThreshold = getTimeAsSeconds("spark.network.timeout",
"120s")
- val executorHeartbeatInterval =
getTimeAsSeconds("spark.executor.heartbeatInterval", "10s")
+ val executorHeartbeatInterval =
get(EXECUTOR_HEARTBEAT_INTERVAL).millis.toSeconds
Review comment:
I think we've used TimeUnit directly for conversion mostly, rather than the
Scala wrappers; I don't feel strongly about it, but it is what the rest of the
file and related code uses.
`TimeUnit.SECONDS.convert(get(EXECUTOR_HEARTBEAT_INTERVAL),
TimeUnit.MILLISECONDS)`
But let's not introduce `EXECUTOR_HEARTBEAT_INTERVAL` in this PR; see below.
This should be a narrow and simple change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
