srowen commented on a change in pull request #24584:
[SPARK-27680][CORE][SQL][GRAPHX] Remove usage of Traversable
URL: https://github.com/apache/spark/pull/24584#discussion_r283077715
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
##########
@@ -183,7 +183,7 @@ trait Block extends TreeNode[Block] with JavaCode {
def doTransform(arg: Any): AnyRef = arg match {
case e: ExprValue => transform(e)
case Some(value) => Some(doTransform(value))
- case seq: Traversable[_] => seq.map(doTransform)
+ case seq: Iterable[_] => seq.map(doTransform)
Review comment:
This is the only part of the change that is of concern. It's internal, but
this now only matches `Iterable` and not `Traversable`, which are not the same
in Scala 2.12. However, AFAICT, no standard class we'd expect here doesn't
extend `Iterable`. See
https://docs.scala-lang.org/overviews/collections/overview.html ; `Seq`, `Set`
and `Map` are also `Iterable` already. This shouldn't change behavior, but
tests will help prove that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
