srowen commented on a change in pull request #24584:
[SPARK-27680][CORE][SQL][GRAPHX] Remove usage of Traversable
URL: https://github.com/apache/spark/pull/24584#discussion_r283110054
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -168,6 +168,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
}
/** Set multiple parameters together */
+ def setAll(settings: Iterable[(String, String)]): SparkConf = {
+ settings.foreach { case (k, v) => set(k, v) }
+ this
+ }
+
+ /**
+ * Set multiple parameters together
+ */
+ @deprecated("Use setAll(Iterable) instead", "3.0.0")
Review comment:
Hm, is it even worth keeping and deprecating this and removing it later?
It'll be source compatible already and binary compatibility isn't guaranteed;
one would have to go out of one's way to call the deprecated method at all,
with a cast or with some odd custom collection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
