srowen commented on a change in pull request #24584:
[SPARK-27680][CORE][SQL][GRAPHX] Remove usage of Traversable
URL: https://github.com/apache/spark/pull/24584#discussion_r283158966
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -168,6 +168,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
}
/** Set multiple parameters together */
+ def setAll(settings: Iterable[(String, String)]): SparkConf = {
+ settings.foreach { case (k, v) => set(k, v) }
+ this
+ }
+
+ /**
+ * Set multiple parameters together
+ */
+ @deprecated("Use setAll(Iterable) instead", "3.0.0")
Review comment:
Calls to `setAll` will now bind to the more specific `Iterable` arg version
in all cases in Spark, and I'm not aware of any Scala classes that aren't
`Iterable` to begin with. One consequence I suppose is that passing an
`Iterator` will use the deprecated method. But it'll still be there. I don't
anticipate we'll remove it until we want to support Scala 2.13 and that won't
be in 3.0. For now, no method is removed so should be no problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
