srowen commented on a change in pull request #24584:
[SPARK-27680][CORE][SQL][GRAPHX] Remove usage of Traversable
URL: https://github.com/apache/spark/pull/24584#discussion_r283110129
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -168,6 +168,15 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
}
/** Set multiple parameters together */
+ def setAll(settings: Iterable[(String, String)]): SparkConf = {
+ settings.foreach { case (k, v) => set(k, v) }
+ this
+ }
+
+ /**
+ * Set multiple parameters together
+ */
+ @deprecated("Use setAll(Iterable) instead", "3.0.0")
Review comment:
One reason I put this forth is that the `TraversableOnce` problem is harder;
its replacement `IterableOnce` doesn't exist in Scala 2.12. The same overload
strategy doesn't work out quite right for the places it's used (generic types
and function signatures make the overload ambiguous). I am considering
proposing just changing the type there for 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
