rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r287494329
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -96,19 +95,13 @@ object AnalysisContext {
class Analyzer(
catalog: SessionCatalog,
conf: SQLConf,
- maxIterations: Int,
- override val lookupCatalog: Option[(String) => CatalogPlugin] = None)
- extends RuleExecutor[LogicalPlan] with CheckAnalysis with LookupCatalog {
+ maxIterations: Int)
+ extends RuleExecutor[LogicalPlan] with CheckAnalysis {
Review comment:
I use this for `FunctionCatalog` in the rules that are defined as objects in
the `Analyzer`. I'd rather keep it in. At a minimum, this change should be in a
separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
